Why does this require the Netlify app to have read and write permission on issues?
howdy @dadrian - please see this post for more in depth information - the TLDR is that you can decline, but you won’t have the full experience (which we think is worth it) without an update to the permissions.
Just based on the announcement I’d guess it’s since you can create a new issue (intended to be unrelated to the specific PR you’re reviewing) from the deploy preview.
Hi, I’m having some trouble understanding how to access this feature, I’ve created a deploy preview (by creating a merge request on Gitlab), the build happened and I can access it as usual through the deploy-preview url, but I don’t I have anything new in there, I was hoping to see some button to activate the new review mode…
Am I doing something wrong?
hi there @richpars ! thanks for your interest. Today, we released this feature for GitHub backed repos, but we are working on GitLab and other repo hosts for the near future!
For those of you — like me — using a Content Security Policy, and not seeing the button, add:
frame-src https://app.netlify.com, and
Note, Chrome still raises 2 warnings:
Origin trial controlled feature not enabled: 'display-capture'. (anonymous) @ netlify.js:1
Error with Permissions-Policy header: Unrecognized feature: 'interest-cohort'.
Oh, ok, that makes sense, though the blog post could have been more explicit about that, it’s easy to miss that it’s only available for Github so far…
Don’t really want to criticise as it does seem like a nice enough feature but… is there no way to disable it?
Seems a bit presumptuous to assume everyone either wants this feature or is ready to use it straight away. An opt in toggle (or even an opt out) would have been nice here.
Hey there, @nicksnell
Thanks so much for reaching out and sharing this feedback. Rather than disable the feature, there are ways to avoid the feature if you wish. You can read an explanation here!
Thanks, that does make sense, but it’s not ideal as it means we have to change our process to deal with the change - I’d rather we choose to accept the feature into our workflows.
Maybe for small teams this doesn’t matter much but for larger/enterprise size teams, this sort of thing is disruptive.
I think we will add a CSP to block the button as mentioned above.
Thank you so much for this feedback, @nicksnell. I will make sure we share this with the appropriate team.
For some reason I’m not getting the new Deploy Previews.
Not sure if I’m doing something wrong.
I’ve tried creating 2 new PRs since the announcement to a site I’m working on and I’m not seeing anything new.
The code is hosted on GitHub so I don’t think it’s the same issue that @richpars was having…
Got a link to your repo or mind Gist-ing your page(s), @lukebennett88? Suggestions would include making sure that the asset is a valid HTML file, ensuring it includes the
Howdy! I’ve been trying to use the new collaborative Deploy Previews but hitting sign in issues when opening the new draw on the previews themselves. I believe I’ve already granted Netlify extra permission on my GitHub account, despite hitting some GitHub 404s. When I try it out I experience the following:
- Click to view deploy preview
- See deploy preview and new Netlify draw button
- Open draw and see a “Sign up to Netlify” view, plus a “Log in” link
- Click the log in link
- Netlify dashboard opens up in a smaller window
- Close window and repeat the above steps
My suspicion is that I’ve somehow broken the permissions when I granted it, and it’s now malformed in some way. It could also be because I’m using Safari and their cross-site tracking is blocking the tool for working entirely.
PS. I’m not concerned at all that isn’t not working as expected, everything else works perfectly well for me and my clients. I just wanted to report this issue so it’s written up somewhere and that it might help others
Love this feature! But is there a way to disable it for a preview deployment or via URL parameter? When doing a lighthouse report on a preview the added scripts will have a major negative impact on the score
@DavidDarnes, interesting. I’ll pass it to the team. Anything notable in dev tools? Does it happen in an incognito window?
@maggo, there’s a rook of suggestions here for you: Netlify GitHub App permission updates with collaborative Deploy Previews - #3 by amussap
No errors in console when viewing the deploy preview or opening the drawer. There’s an error on the Netlify app itself, 404 for
app.bundle.js.map. It does work in Incognito! I’ve tried my clearing cache and logging out and back in with no luck in a regular window. Very weird
Hey there, @DavidDarnes
Thanks for following up, we appreciate it! The team has an open github issue to address what is happening here. In the interim, could you attempt to use it from a different browser? Thank you!
The repo is private, but here’s the deploy preview:
It’s a pretty standard Gatsby site, and all the markup is valid as far as I know.
Happy to provide more info if that helps.