package.json
“netlify-cli”: “^17.29.0”,
“@netlify /build”: “^29.17.3”,
.cicleci/config.yml
name: Publish review site
command: | command: |
cp projects/documentation/content/favicon.ico test/visual cp projects/documentation/content/favicon.ico test/visual
cd test/visual
branch=$(git symbolic-ref --short HEAD) branch=$(git symbolic-ref --short HEAD)
hash=$(echo -n $branch-<< parameters.regression_theme >>-<< parameters.regression_color >>-<< parameters.regression_scale >>-<< parameters.regression_dir >> | md5sum | cut -c 1-32) hash=$(echo -n $branch-<< parameters.regression_theme >>-<< parameters.regression_color >>-<< parameters.regression_scale >>-<< parameters.regression_dir >> | md5sum | cut -c 1-32)
echo hash echo $hash
yarn netlify deploy --alias=$hash --dir=test/visual echo “Current directory is: $(pwd)”
yarn netlify deploy --alias=$hash
command: |
cp projects/documentation/content/favicon.ico test/visual cp projects/documentation/content/favicon.ico test/visual
cd test/visual
branch=$(git symbolic-ref --short HEAD) branch=$(git symbolic-ref --short HEAD)
hash=$(echo -n $branch-hcm | md5sum | cut -c 1-32) hash=$(echo -n $branch-hcm | md5sum | cut -c 1-32)
echo hash echo $hash
yarn netlify deploy --alias=$hash --dir=test/visual echo “Current directory is: $(pwd)”
yarn netlify deploy --alias=$hash
These two fails with the below error only when i upgrade to v17. It works fine with v15
v16 brought in some changes related to monorepo handling and it seems that’s something that could be affecting you. The only way to check what could be happening is if you can share your repo.
Hi @hrishikesh This is the PR
adobe:main
← adobe:tool/netlify-cli
opened 08:48AM - 24 Jul 24 UTC
## Description
## Related issue(s)
<!---
This project only accept… s pull requests related to open issues
- If suggesting a new feature or change, please discuss it in an issue first.
- If fixing a bug, there should be an issue describing it with steps to reproduce.
-->
- This is a breaking change bug which is being tracked with the netlify team
https://answers.netlify.com/t/v17-29-0-is-breaking-circleci-netlify-deploy/122763/2
## Motivation and context
## How has this been tested?
- [ ] _Test case 1_
1. Go here
2. Do this
- [ ] _Test case 2_
1. Go here
2. Do this
- [ ] Did it pass in Desktop?
- [ ] Did it pass in Mobile?
- [ ] Did it pass in iPad?
## Screenshots (if appropriate)
## Types of changes
- [ ] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] Chore (minor updates related to the tooling or maintenance of the repository, does not impact compiled assets)
## Checklist
- [ ] I have signed the [Adobe Open Source CLA](http://opensource.adobe.com/cla.html).
- [ ] My code follows the code style of this project.
- [ ] If my change required a change to the documentation, I have updated the documentation in this pull request.
- [ ] I have read the **[CONTRIBUTING](<(https://github.com/adobe/spectrum-web-components/blob/main/CONTRIBUTING.md)>)** document.
- [ ] I have added tests to cover my changes.
- [ ] All new and existing tests passed.
- [ ] I have reviewed at the Accessibility Practices for this feature, see: [Aria Practices](https://www.w3.org/TR/wai-aria-practices/)
## Best practices
This repository uses conventional commit syntax for each commit message; note that the GitHub UI does not use this by default so be cautious when accepting suggested changes. Avoid the "Update branch" button on the pull request and opt instead for rebasing your branch against `main`.
This is the config file for the circle ci job.
You indeed have a lot of packages in there. The key is to use the --filter
flag to point to the correct site to build. Something like what’s mentioned here: Recommended configuration for monorepo - #4 by hrishikesh
The flow would looks something like: run netlify deploy
from the root of the repo (don’t cd
to any folder to deploy it) and specify the --filter
flag as --filter=<package-name>
.
Does that work for you?