Webm not working under Git(hub) LFS

mfan · May 11, 2020, 8:35pm

Similar to this post about webp not working under LFS, I’m currently experiencing the same exact issue but with webm files – looking at the rendered HTML (it’s a Gatsby site), it looks like the video has been inlined, with a content-length of 129 bytes – likely the pointer from LFS (we’re using Github.)

Once we removed webm from the .gitattributes, the video loaded as intended. Works locally too.

Does anyone else have this issue? Unfortunately I can’t post a link here, but happy to DM a branch link to support staff. In case it matters: the site is password protected. Thank you!

mfan · May 11, 2020, 10:43pm

An example of the issue in action: a <video> tag with a webm source –

Note the mp4 is fine. I’ve now experienced this same issue on two different sites. My solution thus far has been to just remove the webms from LFS but of course that is not optimal or possible with some larger files.

luke · May 12, 2020, 4:33am

Hi, @mfan, I believe I’ve already replied to a parallel inquiry via another channel but I want to share the same information publicly here for anyone else running into this issue.

There are two environment variables which control if and which files get the actual binary file contents downloaded instead of the Git LFS pointers (which is the default for a git clone).

The first is GIT_LFS_ENABLED=true. This determines if the git clone at Netlify will even attempt to download the actual files instead of their text pointers.

However, the second environment variable is not well documented (yet as I have a created feature request to update our public documentation to include this). This second environment variable is the GIT_LFS_FETCH_INCLUDE environment variable.

The current defaults for this are:

GIT_LFS_FETCH_INCLUDE=*.jpg,*.png,*.jpeg,*.svg,*.gif,*.pdf,*.mp4,*.bmp

This can really only be found here (for now as I’ve opened an issue to get our public docs updated to include this):

github.com

netlify/build-image/blob/xenial/buildbot-git-config#L2


      
          [lfs]
          	fetchinclude = *.jpg,*.png,*.jpeg,*.svg,*.gif,*.pdf,*.mp4,*.bmp,*.webp
          [filter "lfs"]
          	clean = git-lfs clean -- %f
          	smudge = git-lfs smudge -- %f
          	required = true

To override these defaults (and download the Webm files in addition to the MP4s), please create a new environment variable which includes all types of file you want to download. For example, you can just add *.webm to the current list with this environment variable:

GIT_LFS_FETCH_INCLUDE=*.jpg,*.png,*.jpeg,*.svg,*.gif,*.pdf,*.mp4,*.bmp,*webm

I’m not 100% but I do suspect the filtering is case-sensitive based on this:

github.com/git-lfs/git-lfs

Git filters are sometimes case sensitive on case insensitive file systems

opened 11:23AM - 26 Sep 16 UTC

closed 08:23PM - 08 Jun 18 UTC

larsxschneider

### Setup ``` git version 2.10.0 git-lfs/1.4.1 (GitHub; darwin amd64; go 1.7) `…`` ### Steps to reproduce ``` bash $ git init . $ echo "test1" > upper.DAT $ echo "test2" > lower.dat $ git add . $ git commit -m "add files to Git" $ git lfs track "*.dat" $ git add . $ git commit -m "move files to LFS" $ rm * $ git checkout . ``` ### Expected behavior A clean working directory. ### Actual behavior ``` bash $ git status On branch master Changes not staged for commit: (use "git add <file>..." to update what will be committed) (use "git checkout -- <file>..." to discard changes in working directory) modified: upper.DAT ``` _Weird for the user:_ As a user you would think that somehow your file was changed. If you run `git checkout -- upper.DAT` to discard any changes (as Git instructs you) nothing will happen. ### What is going on? The `git add .` after the `git lfs track "*.dat"` moved `lower.dat` to Git LFS, but not `upper.DAT` (although it should as this is a case insensitive file system): ``` $ git cat-file blob :upper.DAT test1 $ git cat-file blob :lower.dat version https://git-lfs.github.com/spec/v1 oid sha256:7d6fd7774f0d87624da6dcf16d0d3d104c3191e771fbe2f39c86aed4b2bf1a0f size 6 ``` If you add the `dat/DAT` files _after_ you track the files in LFS then everything works as expected: ``` bash $ git init . $ git lfs track "*.dat" $ echo "test1" > upper.DAT $ echo "test2" > lower.dat $ git add . $ git commit -m "add files to Git LFS" ``` My hunch is that the root of the problem is located in Git core. What do you think?

So, please do include all required case variations.

To summarize, the solution for this will be to include both environment variables at Netlify for this site. Note, these environment variables must be defined in the Netlify web UI for the site. If you defined them in netlify.toml they are in the repo and won’t be used during the git clone because we need to clone the repo in order to see the environment variables. This is why they must be defined in the UI.

If there are other questions about this, please let us know.

mfan · May 12, 2020, 6:11am

Can confirm. Added GIT_LFS_FETCH_INCLUDE to include webm, triggered a rebuild, and voila. All is working.

Thank you @luke for this prompt and thorough explaination!!

luke · May 12, 2020, 10:52am

Glad to hear this resolve the issue, @mfan!

If/when we get our docs updated, we will post an update here to let the community know about it.

Our docs could be clearer and document this better. We’re working on doing just that.

Topic		Replies	Views
Bogus Github LFS file Support deployment , git-lfs	4	1251	September 7, 2022
Unable to access videos stored as large media Support deployment , netlify-large-media-nlm , gatsby	6	2114	May 25, 2020
Webp not working under git lfs Support git-lfs	1	900	January 9, 2020
My video doesn't work Support netlify-large-media-nlm	13	5759	August 31, 2020
"failed to load file from Git-Gateway" in CMS Netlify CMS netlify-large-media-nlm , git-lfs	5	1075	June 3, 2021

Webm not working under Git(hub) LFS

Related topics