I was able to get it to work! I have a bit of feedback though.
It’s pretty bad UX for builds to hang instead of surfacing errors. Are there error messages that get swallowed here? Could the site use better messaging here?
Initially I thought it wasn’t working. I was putting my entire assets folder in lfs, and my favicons weren’t loading. It turns out that for some reason specifically the .ico files were not getting pulled in, and were loading as pointer data when I went to /favicon.ico. I was able to fix this for myself by excluding the .ico files from LFS, but this is kind of strange to me. Why was this happening? Will it miss other files?
Hi, @qoouep, I’d like to research this further before filing a new issue (as I think it may match an existing issue). Would you please send us a link to the deploy with the error above (and you can just send the deploy id from the end of the URL if you prefer)?
This will tell me if there is a swallowed error we could surface.
Regarding question two about the .ico file, this isn’t one of the file type which is clone in binary format. The defaults as listed here:
To get the git lfs clone to include that file extention, an additional environment variable is required, that being GIT_LFS_SMUDGE_FILTER. If you want to include .ico files in addition to the current defaults, this should be set like so (in the Netlify UI only as it won’t work in the repo itself):