Does cli deploy - -message work with - -trigger?

Natetronn · October 21, 2021, 4:00pm

Can anyone confirm Netlify CLI deploy message flag works when run alongside the trigger flag, please? It doesn’t seem to be working on my end.

The following variations trigger the build from main@HEAD on my repo but, I don’t get a deploy message. It just says, “No deploy message” on the Netlify Deploys listing page. And I’m not seeing a message in the logs, either ,but that’s just an aside, as I don’t know if messages end up in logs, either way:

netlify deploy --message "My Message" --trigger
netlify deploy --trigger --message "Just a Message"
netlify deploy --trigger --message="Just another Message"
netlify deploy --trigger -m "And a Message"

Note: I’m running this through a Github Action (workflow) but, have run the commands directly from my local machine and nothing; no deploy message.

Natetronn · October 21, 2021, 4:35pm

I could be wrong but, looking over the deploy command code, I’m not seeing a condition/param for the --message flag. Should I post an issue there?

github.com

netlify/cli/blob/0d2708ec5d20517ec3de32ca6f9dab77b5edd9a1/src/commands/deploy.js#L426-L428


      
          if (flags.trigger) {
            return triggerDeploy({ api, siteId, siteData })
          }

github.com

netlify/cli/blob/0d2708ec5d20517ec3de32ca6f9dab77b5edd9a1/src/commands/deploy.js#L31-L44


      
          const triggerDeploy = async ({ api, siteData, siteId }) => {
            try {
              const siteBuild = await api.createSiteBuild({ siteId })
              log(
                `${NETLIFYDEV} A new deployment was triggered successfully. Visit https://app.netlify.com/sites/${siteData.name}/deploys/${siteBuild.deploy_id} to see the logs.`,
              )
            } catch (error_) {
              if (error_.status === 404) {
                error('Site not found. Please rerun "netlify link" and make sure that your site has CI configured.')
              } else {
                error(error_.message)
              }
            }
          }

coelmay · October 23, 2021, 4:44am

Hi @Natetronn

Given the following line inside the triggerDeploy function

const siteBuild = await api.createSiteBuild({ siteId })

which only passes the siteId, coupled with the documentation which states

Trigger a new build of your site on Netlify without uploading local files

I would say no --trigger does nothing more than trigger a new build. Nothing other than the siteId is sent through.

Natetronn · October 23, 2021, 5:08am

Hi @coelmay, thanks for the reply, I appreciate it.

coelmay · October 23, 2021, 5:11am

If you would like to have a message sent along with a trigger, you could change the issue you logged on GitHub and make it a feature request instead. The maintainers/contributors of the project could then evaluate it and possibly implement it in a future version.

Natetronn · October 23, 2021, 5:28am

I’ve closed that post and started a new feature request using the feature request template. It’s here if anyone’s interested:

github.com/netlify/cli

message flag and its value should work along side trigger flag

opened 05:26AM - 23 Oct 21 UTC

Natetronn

type: feature area: command: deploy

**Is your feature request related to a problem? Please describe.** When runni…ng `neflity deploy --trigger`, along with `--message "Some String"` there is no deploy message registered in the dashboard. **Describe the solution you'd like** I'd like the --message flag to be available when using the --trigger flag and for the message to show up on the Deploy list page of the Netlify Dashboard (and potentially directly in a deploy log, if that's currently the default for deploy logs; otherwise that would be a separate request, which I'm not making.) **Describe alternatives you've considered** None that I'm aware of. **Additional context** You can see messages show up for Github (push) deploys but, when using the CLI with the --trigger and --message flags together, the log is without a deploy message: ![no-deploy-msg](https://user-images.githubusercontent.com/582149/138543488-1f7f251a-088c-4c21-9134-372dfeb4af5c.png) The trigger flag code: https://github.com/netlify/cli/blob/0d2708ec5d20517ec3de32ca6f9dab77b5edd9a1/src/commands/deploy.js#L426-L428 https://github.com/netlify/cli/blob/0d2708ec5d20517ec3de32ca6f9dab77b5edd9a1/src/commands/deploy.js#L31-L44 **Can you submit a pull request?** Yes/No...Maybe? I'm more than happy to contribute but, not sure of myself. I'll read the guidelines, either way. > Pull requests are welcome! If you would like to help us add this feature, please check our > [contributions guidelines](../../CONTRIBUTING.md).

hillary · October 28, 2021, 3:16pm

Thanks so much for linking that feature request! I am sure it will be beneficial to additional Forums members who are looking for something similar.