Node v16.15.1 (npm v8.11.0) breaks some builds

dana-blackbean · June 2, 2022, 7:41pm

We have run into the same problem. After updating the environment variables with v16.15.0 our builds all seem to be working!

nhoizey · June 3, 2022, 9:45pm

I have the same issue, while using Node v16.15.1 (npm v8.11.0).

@dana-blackbean what do you mean with “updating the environment variables with v16.15.0”?

claygiffin · June 3, 2022, 9:51pm

@nhoizey, you can set an environmental variable in Netlify’s dashboard (Site Settings → Build & Deploy → Environment) to dictate which version of node Netlify uses.

Set a variable with the key NODE_VERSION and value 16.15.0.

aakkapeddi · June 3, 2022, 10:28pm

This was incredibly helplful to me thank you!

nhoizey · June 3, 2022, 11:15pm

Ok, instead of an environment variable, I used my already existing .nvmrc file to set Node to 16.5.0, and it now works!

claygiffin · June 5, 2022, 1:15pm

Another fix here: Deploy failed today: Build was terminated: Build script returned non-zero exit code: 1 - #4 by nathanmartin

You can set npm flags in Netlify to build using —force or —legacy-peer-deps. ~~Even if your package-lock file was built using one of those flags, they seem to be broken or ignored by Netlify with 16.15.1.~~

EDIT: Node introduced this error by changing the way the npm ci command builds sites with 16.15.1. Read more on their github issues page.

j-e-clark · June 9, 2022, 3:04pm

Thanks, I had the same issue and resolved it with the NPM_FLAGS environment variable.

tomwrankmore · June 10, 2022, 3:59pm

This was a massive help, I went right round the houses on a Sanity/Gatsby project, I needed to change NODE_VERSION on both studio and web I think.
Thanks!

hrishikesh · June 12, 2022, 12:21pm

Note that, Node 16 has been declared as reaching End Of Life by 2023:

So the long-term solution would be to use NPM_FLAGS instead of downgrading Node Version.

claygiffin · June 12, 2022, 1:27pm

@hrishikesh

Why is NPM_FLAGS needed only starting with npm v8.11.0? We have needed to build with —legacy-peer-deps since npm v7, but suddenly Netlify is requiring an environmental variable to build properly.

I asked this before and didn’t get an answer, but shouldn’t the package-lock file take care of this issue? If I set the proper flags when creating package-lock, I would not expect Netlify to build differently from that.

If we need to use npm flags going forward, I would request supporting the .npmrc file, which already allows us to set flags for a project. At least it would be consistent with your .nvmrc support.

hrishikesh · June 12, 2022, 1:36pm

I dropped answering your question, because you seemed to be interested to prove this is a Netlify problem when it simply is not. But to answer your question, a quick Google search shows this:

github.com/npm/cli

[BUG] npm ci can't resolve dependencies without --force, or --legacy-peer-deps

opened 09:56AM - 08 Jun 22 UTC

closed 08:39AM - 30 Jun 22 UTC

Darkein

Release 8.x Bug Needs Triage

### Is there an existing issue for this? - [X] I have searched the existing i…ssues ### This issue exists in the latest npm version - [X] I am using the latest npm ### Current Behavior I've updated to latest node version which use npm 8.11.0, but the problem exist with versions >= 8.6.0 up to 8.12.1 when I do an `npm install --legacy-peer-deps`, all dependencies are correctly installed and I can start my app. but when my CI try do make an `npm ci`, I have conflit errors ``` shell >npm ci npm ERR! code ERESOLVE npm ERR! ERESOLVE could not resolve npm ERR! npm ERR! While resolving: @nestjs/elasticsearch@8.1.0 npm ERR! Found: @elastic/elasticsearch@5.6.22 npm ERR! node_modules/@elastic/elasticsearch npm ERR! @elastic/elasticsearch@"~5.6.22" from the root project npm ERR! npm ERR! Could not resolve dependency: npm ERR! peer @elastic/elasticsearch@"^7.4.0 || ^8.0.0" from @nestjs/elasticsearch@8.1.0 npm ERR! node_modules/@nestjs/elasticsearch npm ERR! @nestjs/elasticsearch@"~8.1.0" from the root project npm ERR! npm ERR! Conflicting peer dependency: @elastic/elasticsearch@8.2.1 npm ERR! node_modules/@elastic/elasticsearch npm ERR! peer @elastic/elasticsearch@"^7.4.0 || ^8.0.0" from @nestjs/elasticsearch@8.1.0 npm ERR! node_modules/@nestjs/elasticsearch npm ERR! @nestjs/elasticsearch@"~8.1.0" from the root project npm ERR! npm ERR! Fix the upstream dependency conflict, or retry npm ERR! this command with --force, or --legacy-peer-deps npm ERR! to accept an incorrect (and potentially broken) dependency resolution. ``` ### Expected Behavior I should not have any errors when I do `npm ci` since it should use package-lock wich contains all conflict resolutions. If I revert to npm@8.5.5, it works correctly without having to do a new `npm install` ### Steps To Reproduce ``` shell npm init npm install @nestjs/elasticsearch@8.1.0 --package-lock-only npm install @elastic/elasticsearch@5.6.22 --package-lock-only --legacy-peer-deps npm ci ``` you can also try without --package-lock-only but by removing `node_modules` folder ### Environment - npm: 8.11.0 - Node.js: 6.15.1 - OS Name: Alpine - System Model Name: WSL - npm config: ```ini ; "builtin" config from /usr/local/lib/node_modules/npm/npmrc globalignorefile = "/etc/npmignore" prefix = "/usr/local" python = "/usr/bin/python3" ; "user" config from /home/pierre/.npmrc save-prefix = "~" ; node bin location = /usr/bin/node ; cwd = *** ; HOME = /home/pierre ; Run `npm config ls -l` to show all defaults. ```

About this, we could try to pass that on as a feature request (or maybe it already works - I’ve never tried that).

claygiffin · June 12, 2022, 1:59pm

Wait… So you knew the answer to my question before, but didn’t answer because you thought I was slighting Netlify? That’s honestly a bit unprofessional.

Anyways, thank you for the answer. You may want to figure out a way to surface the info about NPM_FLAGS more easily, since it is now required for many (most?) projects.

.npmrc was not working when I initially had this issue, I haven’t tested it since downgrading node.

hrishikesh · June 12, 2022, 2:03pm

The issue is from 4 days ago, we had that discussion a week ago - so to answer that part, no I did not know. The only thing I was sure about was this is a Node.js/npm issue and not a Netlify issue. I tried looking back then, but didn’t find anything useful.

This time, i decided to dig again, with different search queries, and landed on that.

I agree,

Surfacing that information would make more sense. I’ll pass this to the docs team to see what the best way for this would be.

jjayguy23 · June 19, 2022, 9:53pm

oh thank God for this! lol. this fixed my problem, and I learned something new! I was panicking!

hillary · July 15, 2022, 9:21pm

Hey folks!

Just following up here. Our Documentation team has updated our Docs to include setting the NPM_FLAGS environment variable to pass either --force or --legacy-peer-deps to the npm install command that Netlify runs at build time.

Thank you for all of the thoughtful collaboration on this thread, and helping us improve our documentation.

Happy building!

rafamessias · August 24, 2022, 2:18am

Thank you very much!! It was very helpful!

elden · August 25, 2022, 5:09am

Hi @rafamessias

Welcome to the community!

Thanks for letting us know this thread helped you. We always appreciate the feedback!

kmacgregor · September 2, 2022, 9:17pm

That link directs to a Page Not Found.

hillary · September 2, 2022, 10:43pm

Hey there, @kmacgregor

Thanks for raising that point! I have gone back and fixed the link. It should now work

elosscode · October 8, 2022, 7:49pm

Finally!!! Thank you so much!!