Better deployment status in PRs when queued

Features
,
1

The deployment status info in GitHub PRs is awesome!

However I noticed that when a deploy build is stuck in a queue it looks like the integration is broken. Could it not say ‘queuing’?

This is what I get when I checkin another commit on the PR branch and the deploy gets queued. Looks dead.

image
image1953×573 52.3 KB

2

Also when a preview deploy works you get a nice box of results say the deploy deploy is read.

But just above it there is a box that says It was not deployed???

image
image1800×1046 126 KB

3

Ah, the second one may be terminology. I think of the previews form PR or commit as a Preview deployment but you call it a Deploy Preview, ie not really a deployment (though it is). Subtle but may explain my confusion.

4

I also think that GitHub has a “deployments” API that we aren’t using, that is the source of the first message in your screenshot :slight_smile:

But yes, we do call builds from PR’s “deploy previews” since they correspond to the PR but not necessarily to either branch commit since it will be “branch A as merged into branch B for testing”.

I would also like to file a feature request for better notifications around that “not yet started” state for us. Could you help me brainstorm what existing status at GitHub we could use for it? My understanding is they don’t have an analog to our “new” (queued but not yet started) status, but I could be wrong!

1 Like
5

also think that GitHub has a “deployments” API that we aren’t using, that is the source of the first message in your screenshot

Ahah thanks. It’s a bit like error outputs in a IDE that has plugins (VS code -) - if they don’t say who they are when they print something we don’t know who’s complaining :slight_smile:

But yes, we do call builds from PR’s “deploy previews” since they correspond to the PR but not necessarily to either branch commit since it will be “branch A as merged into branch B for testing”.

I see that. I guess it’s my intuitive conceptual model was at odds to that being used. No probs now I get it.

would also like to file a feature request for better notifications around that “not yet started” state for us. Could you help me brainstorm what existing status at GitHub we could use for it? My understanding is they don’t have an analog to our “new” (queued but not yet started) status, but I could be wrong!

Well I’m learning my way with this aspect of GitHub, but yes I can’t see a suitable state you could hook :frowning: I also think If something is committed to the branch and so causes a redeploy then the visual state machine has to start from the beginning again otherwise it will be out of sync. Hmmmmm

If you are using the Checks API the it looks like statuscan be one of queued , in_progress , or completed .

But I’m totally guessing here as I have no experience with GitHub Apps

Steve